[Openais] [PATCH 5/8] COVERITY 11: remove dead code from cpg_iteration_next()

Steven Dake sdake at redhat.com
Fri Nov 20 17:20:53 PST 2009


good for merge

regards
-steve

On Sun, 2009-10-25 at 11:58 +1300, Angus Salkeld wrote:
> Event dead_error_line: Cannot reach this line of code
> Event dead_error_condition: On this path, the condition "error == 1" could not be false
> Also see events: [dead_error_condition][const][new_values]
> 
> 863  		error = (error == CS_OK ? res_lib_cpg_iterationnext->header.error : error);
> 864
> 
> Signed-off-by: Angus Salkeld <angus.salkeld at gmail.com>
> ---
>   lib/cpg.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/cpg.c b/lib/cpg.c
> index f031a95..bac9361 100644
> --- a/lib/cpg.c
> +++ b/lib/cpg.c
> @@ -860,7 +860,7 @@ cs_error_t cpg_iteration_next(
>   			description,
>   			&res_lib_cpg_iterationnext->description);
> 
> -	error = (error == CS_OK ? res_lib_cpg_iterationnext->header.error : error);
> +	error = res_lib_cpg_iterationnext->header.error;
> 
>   	coroipcc_msg_send_reply_receive_in_buf_put(
>   			cpg_iteration_instance->conn_handle);



More information about the Openais mailing list