[Openais] [PATCH 2/8] COVERITY 18: prevent deref after free.

Steven Dake sdake at redhat.com
Fri Nov 20 17:12:02 PST 2009


good catch - good for merge

can you backport for whitetank pls?

thanks
-steve

On Sun, 2009-10-25 at 11:57 +1300, Angus Salkeld wrote:
> Event deref_after_free: Dereferencing freed pointer "pi"
> Also see events: [freed_arg]
> 
> Signed-off-by: Angus Salkeld <angus.salkeld at gmail.com>
> ---
>   services/cpg.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/services/cpg.c b/services/cpg.c
> index b15c253..59d59b2 100644
> --- a/services/cpg.c
> +++ b/services/cpg.c
> @@ -830,6 +830,7 @@ static void message_handler_req_exec_cpg_downlist (
>   	                                            MESSAGE_RES_CPG_CONFCHG_CALLBACK);
>   				list_del (&pi->list);
>   				free (pi);
> +				break;
>   			}
>   		}
>   	}



More information about the Openais mailing list