[Openais] [PATCH] Re: ipc forward port patches merged.

Chrissie Caulfield ccaulfie at redhat.com
Fri Feb 20 00:25:42 PST 2009


Chrissie Caulfield wrote:
> OK,
> 
> I've fixed the quorum & votequorum libraries (there was an '&' missing
> in the connect call!). As it stands they still crash corosync though,
> because it doesn't validate the module ID. As quorum & votequorum are
> not loaded by default, ipc dereferences a NULL pointer. A patch is attached.
>

Committed revision 1772.


> I've half-fixed confdb. But it still does a double-free in
> confdb_finalize/saHandleInstancePut which I'm not sure about.


This has also been fixed now ... more ampersand problems!


Chrissie

> Steven Dake wrote:
>> Chrissie,
>>
>> The patches were fairly functional with some minor breakage in some of
>> the APIs.
>>
>> I went ahead and merged the patches so we all have a consistent base to
>> work from.  We can sort out the breakage in the source tree since its a
>> development tree.
>>
>> Currently the following work:
>> EVS
>> CPG
>> CKPT
>> CLM
>> TMR
>>
>> The following may or may not work and likely require some attention:
>> CONFDB
>> QUOURUM
>> VOTEQUOURUM
>> EVT
>> MSG
>> LCK
>>
>> On Wed, 2009-02-18 at 14:11 +0000, Chrissie Caulfield wrote:
>>> Steven Dake wrote:
>>>> try using touch on the file coroipc.h
>>>>
>>> I don't think that's enough (well, it isn't, I tried!) - looking at the
>>> diff:
>>>
>>>
>>> Index: include/corosync/coroipc.h
>>> ===================================================================
>>> --- include/corosync/coroipc.h  (revision 1764)
>>> +++ include/corosync/coroipc.h  (working copy)
>>> @@ -1,5 +1,6 @@
>>>  /*
>>> - * Copyright (c) 2002-2005 MontaVista Software, Inc.
>>> + * Copyright (c) 2002-2003 MontaVista Software, Inc.
>>> + * Copyright (c) 2006-2007 Red Hat, Inc.
>>>   *
>>>   * All rights reserved.
>>>
>>>
>>> And it's also missing coroipc.c too ....
>>>
>>> Chrissie
>>>
>>>> On Wed, 2009-02-18 at 13:32 +0000, Chrissie Caulfield wrote:
>>>>> Steven Dake wrote:
>>>>>> Here is the first stab at the whitetank IPC forward port into corosync.
>>>>>> Currently CPG and EVS appear to work properly while other services have
>>>>>> various segfaults with the test cases.
>>>>>>
>>>>>> Patches appreciated:)
>>>>> I can't get that patch to apply, its patching a file called coroipc.h
>>>>> that I don't have!
>>>>>




More information about the Openais mailing list