[Openais] [patch] Unnecessary `else' in assembly code of totempg

Steven Dake sdake at redhat.com
Mon Feb 16 14:18:38 PST 2009


On Sun, 2009-02-15 at 02:05 +0900, Masatake YAMATO wrote:
> Hi,
> 
> Could you merge this patch if it is correct?
> 

The optimizer benefits from the else on some archs/compilers and it
doesn't cause any harm so I am inclined to leave it the way it is.

Regards
-steve


> Masatake YAMATO
> 
> Index: exec/totempg.c
> ===================================================================
> --- exec/totempg.c	(revision 1759)
> +++ exec/totempg.c	(working copy)
> @@ -582,7 +582,7 @@
>  			iov_delv.iov_len = msg_lens[1];
>  			start = 1;
>  		}
> -	} else 
> +	}
>  	if (throw_away_mode == THROW_AWAY_INACTIVE) {
>  		if (continuation == assembly->last_frag_num) {
>  			assembly->last_frag_num = mcast->fragmented;
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list