[Openais] [whitetank] ipc-20

[Lars Marowsky-Bree]

On 2009-02-01T20:31:57, Steven Dake <sdake at redhat.com> wrote:

> This is the latest iteration of this patch.
> 
> Some duplicate data structures were moved from lib/util.c and exec/ipc.c
> to include/ipc_gen.h.
> 
> A feature was added to allow applications to use setuid/seteuid syscalls
> without resulting in disconnection of the ipc system and still retaining
> the security model described in the SECURITY document in the root
> directory of the source tree.

I see severe memory leaks with these changes, up to triggering aisexec
to be killed in malloc(), and the clients also leak memory.

No other crashes though.


BTW, I'm again inclined to highlight the usefulness of a dedicated
branch/repo/patch series instead of a single combined patchkit. It would
make this so much easier to review during this development cycle and for
later merge too. Single patchkits are so CVS-1990s ;-)


Regards,
    Lars

-- 
Teamlead Kernel, SuSE Labs, Research and Development
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde