[Openais] logsys patch

[Steven Dake]

Dave,

Looks good - applied

Thanks again!
-steve

On Thu, 2008-07-10 at 15:16 -0500, David Teigland wrote:
> On Wed, Jul 02, 2008 at 09:32:45AM -0500, David Teigland wrote:
> > > It doesn't address the setting of logsys_subsys_id but defines it.  I
> > > want to avoid the situation where logsys_subsys_id is defined, but then
> > > not set.  What I suggest here is to set logsys_subsys_id to some known
> > > value (-1) and assert if that the subsystem id is that value within
> > > log_printf to help developers catch this scenario.  At the moment the
> > > current API enforces proper behavior (it wont link if the developer does
> > > the wrong thing).  With your patch it will link, but may not behave
> > > properly sending log messages to the wrong subsystem (0) instead of the
> > > subsystem desired by the developer.  This is why the macros are there
> > > (to set the subsystem id and define it).  Your patch addresses the
> > > removal of the definition to a generic location but doesn't address at
> > > all the setting of the subsystem id.
> > 
> > Good thought, done.
> 
> That turned out to break things badly :-)  Each file ends up with its own
> static copy of logsys_subsys_id, all of which are initialized to -1, and
> the only instance set to 0 is the one in the file that calls
> logsys_init().  log_printf's in other files assert.
> 
> Attached patch should make it work again.
> 
> Dave
>