[Openais] PATCH: poll problem

Fabien THOMAS fabien.thomas at netasq.com
Thu Aug 24 07:24:06 PDT 2006


> IPC in the aisexec should never block which the proposed change would
> do.  If EAGAIN is returned, the IPC layer will execute poll again
> (rapidly) and pick up the read when the client is able to read.
>
yes it seems that EAGAIN fall into the code that is doing work on  
data received.


> Is this the cause of the ipc lockup you see?  There could be  
> potentially
> some other problem here.
>
no its the patch provided for poll broken on many OS to detect EOF.
> Since IPC has been rewritten several times and most recently for
> threaded behavior, its possible there is a bug, but the above is by
> design.  We should fix the bug and avoid blocking.
>
> Regards
> -steve
>
>> Le 24 août 06 à 14:33, Fabien THOMAS a écrit :
>>
>>> POLLHUP and POLLERR is completly broken on many BSD OS.
>>> Even if the manpage say that it can return it the kernel does not
>>> handle this case...
>>>
>>> I've also added a missing close of a fd on error case.
>>>
>>> Any comment on the patch ?
>>>
>>> Fabien
>>>
>>>
>>> <patch-poll>
>>> _______________________________________________
>>> Openais mailing list
>>> Openais at lists.osdl.org
>>> https://lists.osdl.org/mailman/listinfo/openais
>>
>>
>> _______________________________________________
>> Openais mailing list
>> Openais at lists.osdl.org
>> https://lists.osdl.org/mailman/listinfo/openais
>
>





More information about the Openais mailing list