[Openais] rring part 4 patch

Steven Dake sdake at redhat.com
Wed Apr 12 11:23:42 PDT 2006


New patch with Patrick's suggested fix

On Wed, 2006-04-12 at 16:19 +0100, Patrick Caulfield wrote:
> Steven Dake wrote:
> > On Mon, 2006-04-10 at 10:08 +0100, Patrick Caulfield wrote:
> >> Steven Dake wrote:
> >>> Attached is the redundant ring part 4 patch which uses multiple totemnet
> >>> interfaces if defined and adds the rest of the totemnet abstractions
> >>> into the faulty link detection to avoid doing work on a faulty link for
> >>> send/recv flushes and processor count sets.
> >>>
> >>> Note if you specify multiple interfaces, totem may not work properly as
> >>> the membership layer patch (in totemsrp.c) has not yet been posted and
> >>> still needs some work.
> >>>
> >> I notice that each ring has its own node id. Do these need to be unique or can
> >> they be the same ? ie each node only has the same node ID on each ring ?
> >>
> >> patrick
> >>
> > 
> > Good catch
> > 
> > Patch attached to clean up this oversight.
> > 
> 
> 
> > Index: exec/totemconfig.c
> > ===================================================================
> > --- exec/totemconfig.c	(revision 978)
> > +++ exec/totemconfig.c	(working copy)
> > @@ -166,6 +166,12 @@
> >  				totem_config->secauth = 0;
> >  			}
> >  		}
> > +
> > +		/*
> > +		 * Get interface node id
> > +		 */
> > +		objdb_get_int (objdb, object_interface_handle, "nodeid", &totem_config->node_id);
> 
> This should use object_totem_handle rather than object_interface_handle.
> 
> > +
> >  		objdb_get_int (objdb,object_totem_handle, "threads", &totem_config->threads);
> >  
> >  
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nodeid-fixup-2.patch
Type: text/x-patch
Size: 5954 bytes
Desc: not available
Url : http://lists.linux-foundation.org/pipermail/openais/attachments/20060412/7ce6f080/nodeid-fixup-2-0001.bin


More information about the Openais mailing list