[Openais] [PATCH] Use objdb

Patrick Caulfield pcaulfie at redhat.com
Tue Apr 4 06:38:55 PDT 2006


Steven Dake wrote:
> On Mon, 2006-04-03 at 03:59, Patrick Caulfield wrote:
>> Steven Dake wrote:
>>> Patrick
>>>
>>> Good work exactly what I had in mind.
>>>
>>> Few comments which I'd like resolved before commit
>>>
>>> I really dislike the name "conffile" could we use "aisparser" instead?
>> no problem.
>>
> =

> cool
> =

>>> There seem to be a lot of
>>> -
>>> +
>>> What are these in the patch for?
> =

> ok this is fine I am not opposed to cleaning up the code wherever there
> are problems :)

It's more an affectation than a problem to be honest! I have a "remove
trailing space" macro and I use it almost as a reflex action.

>> They are where my emacs macro has removed trailing spaces at the end of a
>> line. I'll try to tidy them up...but I /hate/ trailing spaces :)
>>
>>> If any "service" parameter is specified, none of the default services
>>> will link with your changes.  What I would prefer is that all default
>>> services link in all cases, and if the user wants a newer version of a
>>> default service, they can specify the service tags in their
>>> configuration file and it will overwrite the key/value pair.
>>>
>>> In the case the default configuration parser is overridden, I would also
>>> like the default services to link.
>>>
>>
>> I was trying to get a system where the user could remove service that we=
re not
>> needed. How about a "defaultservices: " option which defaults to "yes"? =
that
>> way the user could override the default service list if necessary or sim=
ply
>> update versions if that's what is wanted ?
> =

> This works for me.  As long as the user wants to turn off default
> services, they should be able to.  From a support standpoint, I don't
> want services disabled by default though, because it might make for some
> confusion when trying to configure openais.

That sounds fair.

New patch attached.

-- =


patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: objconfig.patch
Type: text/x-patch
Size: 47225 bytes
Desc: not available
Url : http://lists.linux-foundation.org/pipermail/openais/attachments/20060=
404/229f1c94/objconfig-0001.bin


More information about the Openais mailing list