[Openais] More ACTIVE units than the number defined in group.conf exist

[Steven Dake]

Sakai-san,

Great catch your right.  The current distributed state machine (this is
why the code begins with dsm*) expects out of service to be entered from
in_service/active, but this isn't a correct assumption.  The out of
service state can also be entered in in_service/standby.

Over the long term we need a reanalysis of the state machine with a
clear documentation and testing approach.. Its a 3rd generation state
machine, but I am not totally comfortable with it yet.

Could you use the diff -uNr command to make a patch with your change,
and I'll merge the patch?

Regards
-steve

On Fri, 2004-09-03 at 17:59, SAKAI MIYOTAKA wrote:
> Hi ,
> 
> It is the first time to send a message to this mailing-list.
> 
> I am trying to execute the test programs in the openais package.
> But the programs does not work as expected.
> 
> Please take a look at the followings
> 
> ./aisexec
> ./testamf4
> ./testamf3
>   => both HA status are Active
> ./testamf5
> ./testamf6
>   => both are Standby
> ./testamf1
> ./testamf2
>   => both are Standby
> 
> The component in the testamf2 calls a saAmfComponentUnregister function
> after calling a saAmfComponentregister.
> After that ,testamf5 and testamf6 change status as Active.
> But I exepect that both keep Stanby.
> It seems that more ACTIVE units than the number defined in group.conf
> exist.
> 
> If dsmDisabledUnlockedOutOfServiceCompleted funciton in amf.c
>    is changed as following ,programs does work as expected.
> 
> dsmDisabledUnlockedOutOfServiceCompleted( )
> {
>       .
>       .
>     group = unit->saAmfGroup;
> 
>     /* add 3 lines */
>     if ( activeServiceUnitsCount(group) >=
> group->saAmfActiveUnitsDesired ) {
>            retrun;
>     }
> 
>     if (servide UnitOutOfService == 1 ) {
>             log_printf ( LOG ......
>        .
>        .
> }
> 
> If my idea isn't correct ,please tell me what is wrong.
> 
> Thanks.
> Miyotaka Sakai
> 
> 
> 
> ______________________________________________________________________
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/openais