[Openais] Re: event service code number 3

[Mark Haverkamp]

On Thu, 2004-09-02 at 23:09, Steven Dake wrote:
> Mark
> 
> Sorry for the slow response...  My child was born Tuesday at 3:42 AM so
> I've been out of actions for awhile...

Congratulations.  I'm surprised that you have been on the list at all.


> 
> This latest patch looks good to merge with a few nit picks.  Thanks for
> all your hard work on the event service!
> 
> The comment above event_rentention_timeout looks a little fishy:
>  * Check for expired events. Then re-arm the timer.
> If this is wrong could you change it or remove it?
> there is one warning, could you fix before merging?

OK.  I saw this after I sent the patch.  There were a few commented out
pieces of code that I forgot to delete.

> 
> cc -O3 -Wall -I../include -c -o publish.o publish.c
> publish.c: In function `main':
> publish.c:394: warning: control reaches end of non-void function

I'll fix it.  
> 
> Thanks Mark
> -steve
> 
> On Thu, 2004-09-02 at 10:26, Mark Haverkamp wrote:
> > Steve,
> > 
> > Here are the updates from the last round of comments.  I think that I
> > have addressed them. In particular, I changed the retained events
> > expiration to set a timer for each and  implemented the
> > saEvtEventClearRetentionTime code.  The evt dispatch code was updated to
> > use the algorithm used in the evs dispatch.
> > 
> > Look for the patch here:
> > 
> > http://developer.osdl.org/markh/openais/openais_event_20040902.patch
> > 
> > Thanks,
> > Mark.
-- 
Mark Haverkamp <markh at osdl.org>