[linux-pm] [PATCH] irq: provide debug_poll_all_shared_irqs() method under CONFIG_DEBUG_SHIRQ

[Ingo Molnar]

* Rafael J. Wysocki <rjw at sisk.pl> wrote:

> > I did suggest that we could also add some test-infrastructure like the 
> > DEBUG_SHIRQ thing we already have, which sends an interrupt 
> > immediately on resume after interrupts have been enabled. That will 
> > likely uncover a _lot_ of problems, and it's almost certainly worth 
> > doing regardless.
> 
> For the record, I put that onto my todo list, which unfortunately is 
> quite long at the moment (and getting longer).

as i mentioned it in the private thread to Linus, kernel/irq/spurious.c's 
misrouted_irq(-1) function function is precisely what we want to call at 
resume time.

See the patch below, it factors this functionality out and provides a 
debug_poll_shared_irqs() function that you can call from the resume path. 

In the !DEBUG_SHIRQ case it will do nothing, in the DEBUG_SHIRQ case it 
will iterate through all registered IRQs (which are capable of handling 
shared irq lines) and call them (if they are not disabled explicitly).

The sooner we start seeing these kinds of problems the better - delaying 
debug patches to after feature work is never a good idea - delaying 
feature changes works much better ;-)

	Ingo

------------------>