[linux-pm] [RFC][PATCH] PM: Separate suspend and hibernation callbacks (highest level) - updated

Rafael J. Wysocki rjw at sisk.pl
Wed Mar 12 14:22:36 PDT 2008


On Wednesday, 12 of March 2008, David Brownell wrote:
> On Monday 10 March 2008, Rafael J. Wysocki wrote:
> > + * @poweroff: Hibernation-specific, executed after saving a hibernation image.
> > + *     Quiesce the device, put it into a low power state appropriate for the
> > + *     upcoming system state (such as PCI_D3hot), and enable wakeup events as
> > + *     appropriate.
> 
> This seems uncomfortably similar to device_driver.shutdown().
> The only obvious difference is wakeup event handling, and even
> that is already a function of the target system state.
> 
> Are both methods needed?
> 
> Shouldn't this be more generic, not "hibernation-specific"?

Well, let's not make restrictions at this point.  There's nothing wrong with
pointing both at the same function and if everyone turns out to do that, we'll
remove one callback.

Thanks,
Rafael


More information about the linux-pm mailing list