[linux-pm] [PATCH] Device core: Remove dpm_sysfs_remove() from error path of device_add()
Rafael J. Wysocki
rjw at sisk.pl
Mon Mar 3 14:46:51 PST 2008
Hi Greg,
The appended patch fixes a bug in the error path of device_add().
Please accept it for 2.6.25.
Thanks,
Rafael
---
From: Rafael J. Wysocki <rjw at sisk.pl>
Since device_pm_remove(dev) calls dpm_sysfs_remove(dev), it's
incorrect to call the latter after the former in the device_add()
error path.
Signed-off-by: Rafael J. Wysocki <rjw at sisk.pl>
---
drivers/base/core.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/drivers/base/core.c
===================================================================
--- linux-2.6.orig/drivers/base/core.c
+++ linux-2.6/drivers/base/core.c
@@ -839,7 +839,6 @@ int device_add(struct device *dev)
return error;
BusError:
device_pm_remove(dev);
- dpm_sysfs_remove(dev);
PMError:
if (dev->bus)
blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
More information about the linux-pm
mailing list