[KJ] [PATCH] check return code for request_region() in gus_wave.c

Jesper Juhl jesper.juhl at gmail.com
Fri Sep 29 06:16:40 PDT 2006


On 29/09/06, Hashem Masoud <masoudh at batelco.com.bh> wrote:
> Jesper Juhl wrote:
>
> >> +++ linux/sound/oss/gus_wave.c  2006-09-28 20:17:41.093694160 -0300
> >> @@ -2938,7 +2938,10 @@ void __init gus_wave_init(struct address
> >>                         model_num = "3.7";
> >>                         gus_type = 0x37;
> >>                         mixer_type = ICS2101;
> >> -                       request_region(u_MixSelect, 1, "GUS mixer");
> >> +                       if !(request_region(u_MixSelect, 1, "GUS
> >> mixer")) {
> >
> >
> > ... and it shows ^^^^^
>
> BTW, Google web mail access automatically translates tabs into spaces, but if you download your e-mails using POP access this won't happen.

I'm quite aware of that. That's not what I was talking about, and btw,
you'll notice that any mails I send with patches I do *not* send via
the gmail webinterface...

Now, what I *was* talking about was this bit of your patch:  "if
!(request_region"
That should have been  "if (!request_region"


> Also, check the patch posted to list, it is intact:

Again, that's not what I was talking about..


-- 
Jesper Juhl <jesper.juhl at gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html



More information about the Kernel-janitors mailing list