[KJ] [PATCH] check return code for request_region() in
gus_wave.c
Jesper Juhl
jesper.juhl at gmail.com
Thu Sep 28 17:08:57 PDT 2006
On 29/09/06, Hashem Masoud <masoudh at batelco.com.bh> wrote:
> Thanks for your directions. The following is the newest attempt (sorry,
> without compilation as my time is short!)
>
If you don't even have time to test compile your changes then you are
in too much of a hurry ...
> Signed-off-by: Hashem Masoud <masoudh at batelco.com.bh>
> ---
> gus_wave.c | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
> ---
> diff -urp linux-2.6.17.13/sound/oss/gus_wave.c linux/sound/oss/gus_wave.c
> --- linux-2.6.17.13/sound/oss/gus_wave.c 2006-09-27 19:03:42.000000000 -0300
> +++ linux/sound/oss/gus_wave.c 2006-09-28 20:17:41.093694160 -0300
> @@ -2938,7 +2938,10 @@ void __init gus_wave_init(struct address
> model_num = "3.7";
> gus_type = 0x37;
> mixer_type = ICS2101;
> - request_region(u_MixSelect, 1, "GUS mixer");
> + if !(request_region(u_MixSelect, 1, "GUS mixer")) {
... and it shows ^^^^^
Please take the time to do minimal testing. Not doing so is a waste of
a lot of peoples time.
--
Jesper Juhl <jesper.juhl at gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
More information about the Kernel-janitors
mailing list