[KJ] [RFC] request_region() error handling fixes
Domen Puncer
domen at coderock.org
Thu Sep 28 09:42:05 PDT 2006
On 27/09/06 16:15 -0700, Badari Pulavarty wrote:
> On Thu, 2006-09-28 at 00:31 +0200, Jesper Juhl wrote:
> Yes. I considered few other options (and infact, coded to see how
> they look), but settled on "goto".
>
> > Ohh btw, shouldn't there be a single space before your label names? Like
> >
> > out4:
> >
> > instead of
> >
> > out4:
>
> hmm. I haven't seen many of those (I thought, they were typos).
They are intentional, because otherwise diff -p prints them.
And please don't use labels with numbers. I think there was a
patch posted here a week or two ago that had to rename those
numbers, because an error condition could happen in between.
Domen
More information about the Kernel-janitors
mailing list