[KJ] kmalloc to kzalloc patches for drivers/base
Dmitry Torokhov
dtor at insightbb.com
Sun Sep 17 18:08:36 PDT 2006
On Sunday 17 September 2006 20:53, Om Narasimhan wrote:
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 2b8755d..e08950b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -192,7 +192,7 @@ int platform_device_add_resources(struct
> {
> struct resource *r;
>
> - r = kmalloc(sizeof(struct resource) * num, GFP_KERNEL);
> + r = kzalloc(sizeof(struct resource) * num, GFP_KERNEL);
> if (r) {
> memcpy(r, res, sizeof(struct resource) * num);
> pdev->resource = r;
Just out of curiosity could you tell me what is the benefit of
zeroing allocated memory here?
> @@ -216,7 +216,7 @@ int platform_device_add_data(struct plat
> {
> void *d;
>
> - d = kmalloc(size, GFP_KERNEL);
> + d = kzalloc(size, GFP_KERNEL);
> if (d) {
> memcpy(d, data, size);
> pdev->dev.platform_data = d;
>
And here?
--
Dmitry
More information about the Kernel-janitors
mailing list