[PATCH 1/3] Make sockets proper objhash objects and use checkpoint_obj() on them (v2)
danms at us.ibm.com
Thu Sep 3 08:08:08 PDT 2009
SH> Yes. On the struct sock. But what will drop the ref on the
SH> struct socket? Or has one of your later patches, not yet in
SH> ckpt-v17-dev, added that? Or, am I just missing a place where
SH> sock_put() will actually sock_release(sk->sk_socket)?
Hmm, I see what you mean. I can't find any path where sock_put() will
release the struct socket. What's weird is that there is a WARN_ON()
in af_unix.c:354 that should get tripped if we call sk_free() when we
still have a socket. I don't see that, but now I'm not sure why.
Perhaps what we should do is orphan the struct sock before we add it
to the hash and then graft it onto a new struct socket before
attaching it to a struct file?
IBM Linux Technology Center
email: danms at us.ibm.com
More information about the Containers