[Bugme-new] [Bug 13587] New: drivers/serial/bfin_sport_uart.c:235: bad call to memset

bugzilla-daemon at bugzilla.kernel.org bugzilla-daemon at bugzilla.kernel.org
Sat Jun 20 06:27:54 PDT 2009


http://bugzilla.kernel.org/show_bug.cgi?id=13587

           Summary: drivers/serial/bfin_sport_uart.c:235: bad call to
                    memset
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.30
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Serial
        AssignedTo: rmk at arm.linux.org.uk
        ReportedBy: dcb314 at hotmail.com
        Regression: No


memset(buffer, 20, '\0');

Possible newbie coding error in that the 2nd & 3rd
parameter look the wrong way around to me.

Also, the coding police have noticed a lot
of mentions of the fixed constant "20" in the
same routine. Possible improve style by replacing
by a sizeof expression or other symbolic constant ?

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Bugme-new mailing list