[Openais] [PATCH 3/3] STATS: add the service name to the connection name.

[Russell Bryant]

On Mon, Mar 28, 2011 at 4:26 AM, Angus Salkeld <asalkeld at redhat.com> wrote:
> +static const char * short_service_name_get(uint32_t service_id, char *buf)
> +{
> +       const char * name;
> +       switch (service_id) {
> +       case EVS_SERVICE:
> +               name = "EVS";
> +               break;
> +       case CLM_SERVICE:
> +               name = "CLM";
> +               break;
> +       case AMF_SERVICE:
> +               name = "AMF";
> +               break;
> +       case CKPT_SERVICE:
> +               name = "CKPT";
> +               break;
> +       case EVT_SERVICE:
> +               name = "EVT";
> +               break;
> +       case LCK_SERVICE:
> +               name = "LCK";
> +               break;
> +       case MSG_SERVICE:
> +               name = "MSG";
> +               break;
> +       case CFG_SERVICE:
> +               name = "CFG";
> +               break;
> +       case CPG_SERVICE:
> +               name = "CPG";
> +               break;
> +       case CMAN_SERVICE:
> +               name = "CMAN";
> +               break;
> +       case PCMK_SERVICE:
> +               name = "PCMK";
> +               break;
> +       case CONFDB_SERVICE:
> +               name = "CONFDB";
> +               break;
> +       case QUORUM_SERVICE:
> +               name = "QUORUM";
> +               break;
> +       case PLOAD_SERVICE:
> +               name = "PLOAD";
> +               break;
> +       case TMR_SERVICE:
> +               name = "TMR";
> +               break;
> +       case VOTEQUORUM_SERVICE:
> +               name = "VOTEQUORUM";
> +               break;
> +       case NTF_SERVICE:
> +               name = "NTF";
> +               break;
> +       case AMF_V2_SERVICE:
> +               name = "AMF";
> +               break;
> +       case TST_SV1_SERVICE:
> +               name = "TST";
> +               break;
> +       case TST_SV2_SERVICE:
> +               name = "TST";
> +               break;
> +       case MON_SERVICE:
> +               name = "MON";
> +               break;
> +       case WD_SERVICE:
> +               name = "WD";
> +               break;
> +       default:
> +               sprintf(buf, "%d", service_id);
> +               name = buf;
> +               break;
> +       }
> +       return name;
> +}

It would be good to add a "size_t len" argument to this function and
use snprintf() here at the end instead of assuming it is going to be
big enough.

--
Russell Bryant