[Openais] [announce] corosync 1.2.4 released

[Steven Dake]

On 06/11/2010 07:16 AM, Andrew Beekhof wrote:
> On Fri, Jun 11, 2010 at 4:03 PM, Colin<colin.hch at gmail.com>  wrote:
>> On Thu, Jun 10, 2010 at 12:22 AM, Steven Dake<sdake at redhat.com>  wrote:
>>>
>>> This version has the following changes:
>>> * Fixes defects in logsys which are crashing pacemaker installations.
>>
>> Hm, don't know whether I did something wrong, but I just compiled
>> corosync 1.2.4, and then pacemaker 1.0.8, and the pair immediately
>> crashes on startop because pacemaker invokes corosync's getpwnam() in
>> exec/tsafe.c and the assert(0) gets triggered.
>
> The latest versions from Hg have this fixed and it will be in 1.0.9
> thats due "soon"
>

That is very odd.  The tsafe.c code is only in trunk, not the flatiron 
branch.  The release tarball on the website does not include the tsafe.c 
code.  Are you sure you are building the release tarball?

I used release tarballs from http://www.corosync.org to validate with 
pacmaker, and it works for me.

Maybe you were installing from the trunk branch?

>>
>> It seems that tsafe.c wants to enforce, at runtime, that no library
>> loaded into corosync calls a non-thread-safe function in the presence
>> of threads; now the first thing I thought on seeing and (hopefully)
>> understanding tsafe.c was to tell everybody writing extension for
>> corosync to keep their code thread-safe, and throw it away.
>>

more or less true - see below:

>> If, for whatever reasons, it is deemed necessary to keep this run-time
>> work-around, one might go the whole way and implement thread-safe
>> versions of the "offending" functions (on operating systems where it's
>> necessary, for example on Darwin getpwnam() is already
>> thread-safe)...?

Colin,

Our long term plan with tsafe is to have a config option 
"--enable-tsafe" defaulting to off to help developers find non-thread 
safe code.  So in the default case, it wont be on.  This isn't enabled 
in trunk yet, and this code, since it is a debugging tool, won't be 
going into flatiron.

Regards
-steve


>>
>> Regards, Colin
>> _______________________________________________
>> Openais mailing list
>> Openais at lists.linux-foundation.org
>> https://lists.linux-foundation.org/mailman/listinfo/openais
>>
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais