[Openais] Corosync Patch: Fix the default for COROSYNC_RUN_DIR
andrew at beekhof.net
Sun Apr 11 01:30:19 PDT 2010
On Sun, Apr 11, 2010 at 1:59 AM, Steven Dake <sdake at redhat.com> wrote:
> On Sat, 2010-04-10 at 13:35 +0200, Andrew Beekhof wrote:
>> On Sat, Apr 10, 2010 at 6:18 AM, Fabio M. Di Nitto <fdinitto at redhat.com> wrote:
>> > On 4/9/2010 8:17 PM, Steven Dake wrote:
>> >> On Fri, 2010-04-09 at 15:05 +0200, Andrew Beekhof wrote:
>> >>> This looks like a copy/paste error to me...
>> >>> The "RUN" in COROSYNC_RUN_DIR would seem to imply /var/run
>> >>> Also /var/lib is persistent and doesn't need to be created at startup.
>> >>> On the other-hand, LSB states that the contents of /var/run is blow
>> >>> away at boot time.
>> >>> So I'm reasonably sure the following patch is correct.
>> >>> Please ACK.
>> >> In general "rundir" should probably be renamed to "libdir" since the
>> >> idea is that data stored there is persistent.
>> >> Totem requires persistence between node boots of data stored with the
>> >> rundir path.
>> > /var/lib/corosync should be created at "make install" time and it愀
>> > guaranteed to be there by packaging and after each reboot.
>> > /var/run/corosync is more complicated. As Andrew already mentioned LSB,
>> > we need to make sure that it愀 created at startup time. Most daemons can
>> > do that in the init script and be done with it. Corosync doesn愒 have
>> > that luxury because it can be invoked in several different ways (cman
>> > for example), therefor it needs to do the dir creation/check within the
>> > code as the init script is not always used.
>> > This is the problem we need to address basically.
>> And what the patch does :-)
>> There is no need, at runtime, to create /var/lib/corosync.
>> Particularly if its required to be persistent.
>> /var/run/corosync is a different story as Fabbio reiterated above.
>> So given all that, the original patch makes the most sense.
> Oh missed the patch sorry.
> I did review it just now. Hate to be a stickler to details, but the
> rundir environment + variable names should be something like lib instead
> (what is this called?).
Oh I see what you mean.
rundir is used elsewhere in totemsrp.c
I'll send through a new patch which leaves that part intact.
> I guess we can continue to create the dirs if
> they don't exist for self-installs.
More information about the Openais