[Openais] [PATCH] Re: ipc forward port patches merged.
ccaulfie at redhat.com
Thu Feb 19 00:56:24 PST 2009
I've fixed the quorum & votequorum libraries (there was an '&' missing
in the connect call!). As it stands they still crash corosync though,
because it doesn't validate the module ID. As quorum & votequorum are
not loaded by default, ipc dereferences a NULL pointer. A patch is attached.
I've half-fixed confdb. But it still does a double-free in
confdb_finalize/saHandleInstancePut which I'm not sure about.
Steven Dake wrote:
> The patches were fairly functional with some minor breakage in some of
> the APIs.
> I went ahead and merged the patches so we all have a consistent base to
> work from. We can sort out the breakage in the source tree since its a
> development tree.
> Currently the following work:
> The following may or may not work and likely require some attention:
> On Wed, 2009-02-18 at 14:11 +0000, Chrissie Caulfield wrote:
>> Steven Dake wrote:
>>> try using touch on the file coroipc.h
>> I don't think that's enough (well, it isn't, I tried!) - looking at the
>> Index: include/corosync/coroipc.h
>> --- include/corosync/coroipc.h (revision 1764)
>> +++ include/corosync/coroipc.h (working copy)
>> @@ -1,5 +1,6 @@
>> - * Copyright (c) 2002-2005 MontaVista Software, Inc.
>> + * Copyright (c) 2002-2003 MontaVista Software, Inc.
>> + * Copyright (c) 2006-2007 Red Hat, Inc.
>> * All rights reserved.
>> And it's also missing coroipc.c too ....
>>> On Wed, 2009-02-18 at 13:32 +0000, Chrissie Caulfield wrote:
>>>> Steven Dake wrote:
>>>>> Here is the first stab at the whitetank IPC forward port into corosync.
>>>>> Currently CPG and EVS appear to work properly while other services have
>>>>> various segfaults with the test cases.
>>>>> Patches appreciated:)
>>>> I can't get that patch to apply, its patching a file called coroipc.h
>>>> that I don't have!
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 444 bytes
Desc: not available
Url : http://lists.linux-foundation.org/pipermail/openais/attachments/20090219/9cb61d50/attachment.bin
More information about the Openais