[Openais] [PATCH]: openais/trunk: Initial patch for OpenAIS TMR service
sdake at redhat.com
Wed Feb 11 11:02:27 PST 2009
First excellent work!
The IPC messages should be mar_XXX and all parameters including the data
type should be __attribute((aligned(8)))) or however the code goes.
tmr_time_now should be deleted and instead the api call
api->timer_time_get should be used (and also implemented.:)
tmr_timer_create defines no function. Is that intentional?
entering and exiting of a function should be marked with ENTER() and
LEAVE() instead of printfs.
revert the changes in openaisserviceenable relating to the openais_clm
and openais_evt lines (adding an extra space).
what can I say - great work!
On Wed, 2009-02-11 at 12:19 -0600, Ryan O'Hara wrote:
> This patch contains the initial implementation of the OpenAIS TMR
> Most of the service API calls are implemented. The exception is
> saTmrTimerRemainingTimeGet. This call should return the time until the
> next expiration of a periodic timer. To implement this in a sane
> manner will require changes to the corosync API, which are currently
> being designed and will be included in a separate patch.
> Another missing bit of code is the code to check is an absolute timer
> has an initial expire time in the past. This is invalid, and this
> check should be done in the corosync timer API code. Until that code
> is completed, you should be careful when adding absolute timers.
> This patch contains many debugging printf's and log_printf's. These
> will be removed in the future.
> A test program is included (testtmr.c).
> Openais mailing list
> Openais at lists.linux-foundation.org
More information about the Openais