[Openais] [PATCH] Fix bug with queue group insert/remove

Steven Dake sdake at redhat.com
Mon Sep 22 13:07:17 PDT 2008


looks good for merge

Regards
-steve

On Mon, 2008-09-22 at 13:05 -0500, Ryan O'Hara wrote:
> Here is a patch that fixes a couple bugs when adding/removing a queue
> to/from a queue group.
> 
> When inserting a queue into a queue group, we must check that the
> queue is not already a member of the group. If it is, then return
> SA_AIS_ERR_EXISTS.
> 
> When removing a queue from a queue group, we must check that the queue
> is actually a member of the group. If it is not, the return
> SA_AIS_ERR_NOT_EXIST.
> 
> I've added a function called group_queue_find that takes a queue group
> and a queue name and returns a pointer to the queue if the queue is a
> member of the group. If not, it returns NULL.
> 
> This patch also has some code cleanup. Some debug information was
> removed, since it was only there to aid in development. I also
> modified queue_find and group_find such that they take the list that
> we wish to search. As a result, we no longer need sync_queue_find and
> sync_group_find. Other minor code cleanup is also included.
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list