[Openais] [PATCH] Remove obsolete / unused global debug option.

Steven Dake sdake at redhat.com
Mon Oct 20 14:48:43 PDT 2008


Angus,

Please commit the man page change.  I will merge the mainconfig changes
into the logsysv2 patch.

Thanks again

Regards
-steve

On Mon, 2008-10-20 at 13:52 +1300, angus salkeld wrote:
> No point providing this option if nothing happens
> as a result of setting it.
> 
> Signed-off-by: Angus Salkeld <angus.salkeld at alliedtelesis.co.nz>
> ---
>  exec/mainconfig.c   |   12 ------------
>  man/corosync.conf.5 |   14 --------------
>  2 files changed, 0 insertions(+), 26 deletions(-)
> 
> diff --git a/exec/mainconfig.c b/exec/mainconfig.c
> index 5600a47..4e6abdd 100644
> --- a/exec/mainconfig.c
> +++ b/exec/mainconfig.c
> @@ -109,8 +109,6 @@ int corosync_main_config_read (
>  	char *error_reason = error_string_response;
>  	unsigned int object_find_handle;
>  	unsigned int object_find_logsys_handle;
> -	int global_debug = 0;j
> -
>  
>  	memset (main_config, 0, sizeof (struct main_config));
>  
> @@ -150,16 +148,6 @@ int corosync_main_config_read (
>  			}
>  		}
>  
> -		if (!objdb_get_string (objdb,object_service_handle, "debug", &value)) {
> -                        if (strcmp (value, "on") == 0) {
> -                                global_debug = 1;
> -                        } else
> -                        if (strcmp (value, "off") == 0) {
> -                                global_debug = 0;
> -                        } else {
> -                                goto parse_error;
> -                        }
> -                }
>  		if (!objdb_get_string (objdb,object_service_handle, "timestamp", &value)) {
>  			if (strcmp (value, "on") == 0) {
>  				main_config->logmode |= LOG_MODE_DISPLAY_TIMESTAMP;
> diff --git a/man/corosync.conf.5 b/man/corosync.conf.5
> index 2ed071a..c915b09 100644
> --- a/man/corosync.conf.5
> +++ b/man/corosync.conf.5
> @@ -435,20 +435,6 @@ directive is set to
>  No default.
>  
>  .TP
> -debug
> -This specifies whether debug output is logged for all services.  This is
> -generally a bad idea, unless there is some specific bug or problem that must be
> -found in the executive. Set the value to 
> -.B on
> -to debug, 
> -.B off
> -to turn off debugging. If enabled, individual loggers can be disabled using a
> -.B logger_subsys
> -directive.
> -
> -The default is off.
> -
> -.TP
>  timestamp
>  This specifies that a timestamp is placed on all log messages.
>  



More information about the Openais mailing list