[Openais] exec/ipc.c bug?

Steven Dake sdake at redhat.com
Fri Nov 10 09:37:29 PST 2006


Hans,

I have fixed this in the whitetank branch a long time ago and must have
forgot to merge the patch into trunk.

For all the core code, whitetank should be used.  Please copy over ipc.c
from the whitetank branch.  It solves this problem properly without the
need for dereference checks all over the place.  (adds to the conn info
list in the right time instead of the wrong time).

I intend in a few days to analyze anything that was missed and get trunk
up to date wrt stability and bug fixes.

Regards
-steve

On Wed, 2006-11-08 at 17:08 +0100, Hans Feldt wrote:
> There are several places in ipc.c where conn_info_partner is 
> dereferenced without validation.
> 
> Steven, pls check this.
> 
> Regards,
> Hans
> 
> Hans Feldt wrote:
> > I got a segv on a null pointer in ipc.c. Possible fix attached.
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > Index: exec/ipc.c
> > ===================================================================
> > --- exec/ipc.c	(revision 1291)
> > +++ exec/ipc.c	(working copy)
> > @@ -931,7 +931,9 @@
> >  
> >  		conn_info = list_entry (list, struct conn_info, list);
> >  		conn_info->flow_control_enabled = 1;
> > -		conn_info->conn_info_partner->flow_control_enabled = 1;
> > +		if (conn_info->conn_info_partner != NULL) {
> > +			conn_info->conn_info_partner->flow_control_enabled = 1;
> > +		}
> >  	}
> >  }
> >  
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Openais mailing list
> > Openais at lists.osdl.org
> > https://lists.osdl.org/mailman/listinfo/openais
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/openais




More information about the Openais mailing list