[Openais] PATCH: bug in CheckpointWrite

Steven Dake sdake at redhat.com
Mon Aug 21 21:33:21 PDT 2006


Looks good for trunk.

Let me commit to whitetank please.

Regards
-steve

On Fri, 2006-08-18 at 11:12 +0200, Fabien THOMAS wrote:
> while testing my program i've discovered that when you write a 0  
> sized vector
> saCkptCheckpointWrite return a random error code.
> 
> any comment on the patch before commit ?
> 
> --- ckpt.c      (revision 1220)
> +++ ckpt.c      (working copy)
> @@ -1500,10 +1500,12 @@
>          for (i = 0; i < numberOfElements; i++) {
>                  if (ioVector[i].dataSize == 0) {
>                          *erroneousVectorIndex = i;
> +                       error = SA_AIS_ERR_INVALID_PARAM;
>                          goto error_put;
>                  }
>                  if (ioVector[i].dataBuffer == NULL) {
>                          *erroneousVectorIndex = i;
> +                       error = SA_AIS_ERR_INVALID_PARAM;
>                          goto error_put;
>                  }
>          }
> $
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/openais




More information about the Openais mailing list