[Openais] PATCH: bug in CheckpointWrite

[Muni Bajpai]

Is there a SAF mandate for the error code on this one ? We need to be 
careful about any changes to the interface as we have had conformance 
issues.

The code looks fine to me.

- Muni
----- Original Message ----- 
From: "Fabien THOMAS" <fabien.thomas at netasq.com>
To: <openais at lists.osdl.org>
Sent: Friday, August 18, 2006 4:12 AM
Subject: [Openais] PATCH: bug in CheckpointWrite


while testing my program i've discovered that when you write a 0
sized vector
saCkptCheckpointWrite return a random error code.

any comment on the patch before commit ?

--- ckpt.c      (revision 1220)
+++ ckpt.c      (working copy)
@@ -1500,10 +1500,12 @@
         for (i = 0; i < numberOfElements; i++) {
                 if (ioVector[i].dataSize == 0) {
                         *erroneousVectorIndex = i;
+                       error = SA_AIS_ERR_INVALID_PARAM;
                         goto error_put;
                 }
                 if (ioVector[i].dataBuffer == NULL) {
                         *erroneousVectorIndex = i;
+                       error = SA_AIS_ERR_INVALID_PARAM;
                         goto error_put;
                 }
         }
$

_______________________________________________
Openais mailing list
Openais at lists.osdl.org
https://lists.osdl.org/mailman/listinfo/openais