[Openais] [PATCH] Use objdb

Patrick Caulfield pcaulfie at redhat.com
Mon Apr 10 02:40:32 PDT 2006


Hans Feldt wrote:
> =

> A couple of things:
> =

> 1. The default user/group config is not working. A line with:
> =

>     objdb->object_find_reset (OBJECT_PARENT_HANDLE);
> =

> before the aisexec section fixes the problem.
> =

> 2. BUILD_DYNAMIC=3D0 does not work. amfconfig.c missing in build.

Good catch, I've fixed those two now. (patch attached).

> =

> 3. Now when we have this nicer way of configuring user/group, why not
> revert, take out my patch where it was configured at compile time? We
> only need one way of doing this and this is the best way.
> =

> 4. I think the location of openais.conf should be configurable at the
> aisexec command line and not at compile time. Of course defaults to
> /etc/ais.
> =

> 5. I don't understand why the "amf-mode-enabled" needs to be there. If
> some Openais user does not want the AMF service, delete
> service_amf.lcrso and its not loaded! Maybe some other Openais user does
> not want service X, should there be a x-mode-enabled then? If needed
> (due to static linked services?), the logic should be inverted to
> amf-mode-disabled: yes/no
> =

> 6. The location of groups.conf should be configurable in openais.conf.
> Why? groups.conf is probably cluster specific and openais.conf is node
> specific and probably stored in different directories.
> =

> I have reworked the daemon patch that Bjorn Andersson sent to the
> mailing list (it got lost?), I could include the stuff (3-6) in there if
> you like?
> =


I deliberately left the AMF stuff as it was so that it could be tackled by
those who really know what needs to be done there :)

-- =


patrick
-------------- next part --------------
Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- Makefile	(revision 976)
+++ Makefile	(working copy)
@@ -53,8 +53,8 @@
 EXEC_LIBS =3D libtotem_pg.a
 =

 # service handler objects
-SERV_SRC =3D evs.c clm.c amf.c ckpt.c evt.c lck.c msg.c cfg.c cpg.c aispar=
ser.c
-SERV_OBJS =3D evs.o clm.o amf.o ckpt.o evt.o lck.o msg.o cfg.o cpg.o aispa=
rser.o
+SERV_SRC =3D evs.c clm.c amf.c ckpt.c evt.c lck.c msg.c cfg.c cpg.c amfcon=
fig.c aisparser.c
+SERV_OBJS =3D evs.o clm.o amf.o ckpt.o evt.o lck.o msg.o cfg.o cpg.o amfco=
nfig.o aisparser.o
 =

 # main executive objects
 MAIN_SRC =3D main.c print.c mempool.c \
Index: mainconfig.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- mainconfig.c	(revision 977)
+++ mainconfig.c	(working copy)
@@ -138,6 +138,7 @@
 		}
 	}
 =

+	objdb->object_find_reset (OBJECT_PARENT_HANDLE);
 	if (objdb->object_find (
 		    OBJECT_PARENT_HANDLE,
 		    "aisexec",


More information about the Openais mailing list