[Openais] Re: evt patch for channel open async

Steven Dake sdake at mvista.com
Mon Feb 7 17:45:06 PST 2005


patch looks good

one comment

the time conversion done with the divide is somewhat of a magic number
(search for 10000).˙  Think you could describe it or give a descriptive
functional name?

We may have discussed this before but I can't remember.  It looks as
though the library handler for event is opening up the channel.  Is this
open ordered through totem?  Did you fix the races (or did you decide
there were none) with this?  I can't remember..  While not critical, I'd
like to track this if its still a remaining issue to be solved after our
initial release.

Please commit the patch when you have some change for the time issue.

Thanks for the patch Mark
-steve



On Mon, 2005-02-07 at 15:19, Mark Haverkamp wrote:
> Here is a patch for the SaEvtChannelOpenAsync function.  Its part of the
> B spec.  I updated the testevt program to do a simple async open and
> check that the callback gets called with no errors, has the correct
> invocation value, and can be closed using the supplied channel handle.
> 
> I also fixed a small bug in the event retention clear code that has been
> there forever but showed up when I added the new async message.
> 
> Mark.
> 




More information about the Openais mailing list