[Openais] Re: A bug for AMF

Steven Dake sdake at mvista.com
Mon Oct 18 16:28:50 PDT 2004


Sakai-san
My apologies but I don't see any mails recently with a patch attached
from you.  Could you resend it?

Thanks
-steve

On Mon, 2004-10-18 at 16:02, Miyotaka Sakai wrote:
> Steve,
> 
> I would like your comment and advice on the patch
> that was attacted to the E-mail I sent.
> 
> I don't mind whether you give me severe comment.
> I'll reconsider and fix that.
> 
> By the way, I have other jobs on bugzilla that are 140 and 157.
> I'll correct these bug first ?
> (I'm going to do that ,after I fix this bug.)
> 
> regards
> -Miyotaka Sakai
> 
> Miyotaka Sakai wrote:
> > Steve,
> > 
> > Could you review the patch attached to E-mail instead of last one.
> > Some change is added.
> > 
> > And response in line.
> > 
> > Miyotaka Sakai wrote:
> > 
> >> Steave,
> >>
> >> I made the patch ,and attached this Email.
> >> This patch include 2 bugs (142,143).
> >>
> >> response in line .
> >>
> >> Steven Dake wrote:
> >>
> >>> Miyotaka-san
> >>>
> >>> I'm not sure if I was clear with dsmDisabledUnlockedFailed.  This is why
> >>> SA_AMF_NOT_RESPONDING must be removed from your patch to work.  The
> >>> reason is because you are sending a message with HIGH priority in this
> >>> case when doing RECOVERY messages which causes the state machine to
> >>> break down.
> >>> By encoding the priority into the state machine,
> >>> dsmDisabledUnlockedFailed will have the priority value to cause send
> >>> the right hastatesetcluster or readinesssattesetcluster messages. 
> >>
> >>
> >> I agree with you .
> >> I'll avoid using RECOVERY priority in readinessSetClusetr and
> >>   hastateSetCluseter .
> >>
> >> Regarding SA_AMF_NOT_RESPONDING :
> >> In component_unregister () ,SA_AMF_NOT_RESPONDING is needed .
> >> In this case ,all messages must not be deliverded to library.
> >> But in component_register () ,SA_AMF_NOT_RESPONDING isn't needed .
> >> In this case ,some messages has to be deliverded to library.
> >> For example HealthchekCallback and OtherCallbacks.
> >> Of course ,program shouldn't send response to saAmfComponentUnregister.
> > 
> > 
> > I misunderstood SA_AMF_NOT_RESPONDING.
> > When SA_AMF_NOT_RESPONDING is set, HealethcheckcCallback is delibderd.
> > I'm sorry about that.
> > 
> > But this case ,SA_AMF_NOT_RESPONDING isn't needed.
> > Becase in order to avoid sending response to saAmfComponentUnregister,
> > this patch take another way.
> > 
> > Thanks
> > - Miyotaka Sakai
> > 
> >>
> >> This Patch is added mesage IF (req_exec_amf_componentregister) change.
> >> In order to scynchronize component date quickly ,this change is neede 
> >> ,I think. (Should I add another message IF ? )
> >>
> >> This patch work well comparably.
> >>
> >> Thanks
> >> - Miyotaka
> >>
> >>> Thanks
> >>> -steve
> 
> 




More information about the Openais mailing list