[Openais] Re: Some event service code

Mark Haverkamp markh at osdl.org
Thu Jul 29 14:46:50 PDT 2004


On Thu, 2004-07-29 at 14:18, Steven Dake wrote:
> On Thu, 2004-07-29 at 12:52, Mark Haverkamp wrote:
> > On Thu, 2004-07-29 at 12:10, Steven Dake wrote:
> > > On Thu, 2004-07-29 at 08:15, Mark Haverkamp wrote:
> > 
> > [ ... ]
> > 
> > > > 
> > > > I'll update the code and send out another patch for you to merge,
> > > > probably this afternoon.  Then I'll start filling in the server side
> > > > code and send updates as things get working.  If that sounds OK.
> > > > 
> > > > > 
> > > 
> > > sounds good Mark
> > > 
> > 
> > I think that I've addressed the comments.  I've gone through the files
> > with tabstop=4 set and lined things up. I moved the get time function to
> > util.[ch], fixed the static declarations, the missing puts, etc.
> > 
> 
> The patch looks good.  You should have write access to the repository;
> can you merge the patch?

Yes, I can do that.

> 
> I'd like to see anything that touches the common files (ie: not directly
> part of the event lib, service, tests) as patches on the mailing list
> before commits.  Patches for the evt stuff would also be helpful to get
> more peer review before commits.

Makes sense.

> 
> > I fixed the destructor to free up the queue so I think it should work in
> > all cases now.  One question that I have is: what if there are some
> > items on the queue when the destructor is called?  Would they be lost
> > when the queue is deleted?  Maybe this can't happen.
> > 
> 
> Yes they would leak.  The queue code is just an queue of data structures
> (in this example, pointers to addresses).  You would want to read all of
> the inq and release every message.  
> 
> Thanks for pointing this out; I think there are leaks in the amf and clm
> code destructors too...

I found something else that I think is a leak.  The dispatch functions
that use the queue don't ever free up the queued message once it it
copied to dispatch_data.


> 
> > I also have a program that I use to test event library functions placed
> > into the test directory.
> > 
> 
> I read through your tests.  Looks pretty thourough.
> 

Thanks,
Mark.

-- 
Mark Haverkamp <markh at osdl.org>




More information about the Openais mailing list